Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate FinalityUpdate in ChainWatcher #180

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Avoid duplicate FinalityUpdate in ChainWatcher #180

merged 1 commit into from
Nov 27, 2023

Conversation

LEAFERx
Copy link
Contributor

@LEAFERx LEAFERx commented Nov 27, 2023

Core changes

  • Only update finalized blocks if it has changed to avoid spamming the channel

ncitron
ncitron approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM!

@ncitron ncitron merged commit 5e14808 into a16z:master Nov 27, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LEAFERx @ncitron